[Asterisk-code-review] rtp engine: rtcp report to json can overflow the ssrc intege... (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10151 )

Change subject: rtp_engine: rtcp_report_to_json can overflow the ssrc integer value
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/10151/2/include/asterisk/json.h
File include/asterisk/json.h:

https://gerrit.asterisk.org/#/c/10151/2/include/asterisk/json.h@84
PS2, Line 84: #ifdef HAVE_LLONG_MAX
> I'm not sure if it's possible to support 'long long' without strtoll() existing, but jansson configu […]
doubtful, but based on briefly looking around I don't see anything that specifically makes mention of it so I'll add that check too just in case.



-- 
To view, visit https://gerrit.asterisk.org/10151
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0
Gerrit-Change-Number: 10151
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 20:10:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180917/84db0113/attachment.html>