[Asterisk-code-review] rtp engine: rtcp report to json can overflow the ssrc intege... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10149 )

Change subject: rtp_engine: rtcp_report_to_json can overflow the ssrc integer value
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Also need a topic set

https://gerrit.asterisk.org/#/c/10149/1/main/rtp_engine.c
File main/rtp_engine.c:

https://gerrit.asterisk.org/#/c/10149/1/main/rtp_engine.c@2525
PS1, Line 2525: 			"source_ssrc", payload->report->report_block[i]->source_ssrc,
We need to cast the source_ssrc to the asterisk equivalent to json_int_t to ensure that we push onto the stack the correct integer size for the platform.


https://gerrit.asterisk.org/#/c/10149/1/main/rtp_engine.c@2558
PS1, Line 2558: 		"ssrc", payload->report->ssrc,
same



-- 
To view, visit https://gerrit.asterisk.org/10149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0
Gerrit-Change-Number: 10149
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 22:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180914/02d40a03/attachment.html>