[Asterisk-code-review] res pjsip: Log IPv6 addresses correctly (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10058 )

Change subject: res_pjsip: Log IPv6 addresses correctly
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Other than this minor nit I don't see anything else.

https://gerrit.asterisk.org/#/c/10058/2/res/res_pjsip_transport_websocket.c
File res/res_pjsip_transport_websocket.c:

https://gerrit.asterisk.org/#/c/10058/2/res/res_pjsip_transport_websocket.c@441
PS2, Line 441: 			ast_debug(4, "%s re-writing Contact URI from %s%.*s%s:%d%s%.*s to %s;transport=%s\n",
Since we are in a DEBUG_ATLEAST() condition clause there is no need to use ast_debug which will redundantly do its own DEBUG_ATLEAST check.

s/ast_debug(4,/ast_log(LOG_DEBUG,/



-- 
To view, visit https://gerrit.asterisk.org/10058
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cfe997ced7883862a12b9c7d8551d76ae02fcf8
Gerrit-Change-Number: 10058
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 19:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180914/ff8b9379/attachment.html>