[Asterisk-code-review] stasis cache: Stop caching stasis subscription change messages (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10136 )

Change subject: stasis_cache:  Stop caching stasis subscription change messages
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10136/1/main/stasis_cache.c
File main/stasis_cache.c:

https://gerrit.asterisk.org/#/c/10136/1/main/stasis_cache.c@822
PS1, Line 822: 	/* There's no longer any need to need to cache every subscribe and unsubscribe */
> This comment presumes knowledge of a previous need to cache every sub/unsub which a future reader ma […]
I agree - I think instead the comment should elaborate on why it is not necessary and what should be done instead if a consumer needs this information.



-- 
To view, visit https://gerrit.asterisk.org/10136
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I321c708505f5ad8d00e1b0afc4c27dc2ac12ecb4
Gerrit-Change-Number: 10136
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 09:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180914/265486e6/attachment.html>