[Asterisk-code-review] pjsip/publish/ presence related tests affected by lua config (testsuite[15.6])

Joshua Colp asteriskteam at digium.com
Thu Sep 13 04:14:49 CDT 2018


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/10102 )

Change subject: pjsip/publish/ presence related tests affected by lua config
......................................................................

pjsip/publish/ presence related tests affected by lua config

Several of the pjsip publish tests that related to custom presence would fail on
some systems if pbx_lua loaded the default/sample configuration. When loaded an
initial extra "Ready" state would be sent and would fail the test.

This patch makes it so the tests do not load pbx_lua at all.

Change-Id: I7413184f13a0d85459d21d7ad701a83c13ba66f4
---
M tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/modules.conf.inc
M tests/channels/pjsip/publish/presence_pidf/configs/ast1/modules.conf.inc
M tests/channels/pjsip/publish/presence_xpidf/configs/ast1/modules.conf.inc
3 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Richard Mudgett: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/modules.conf.inc b/tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/modules.conf.inc
index 2cd4d13..c1a205b 100644
--- a/tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/modules.conf.inc
+++ b/tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/modules.conf.inc
@@ -1 +1,2 @@
 noload => pbx_ael.so
+noload => pbx_lua.so
diff --git a/tests/channels/pjsip/publish/presence_pidf/configs/ast1/modules.conf.inc b/tests/channels/pjsip/publish/presence_pidf/configs/ast1/modules.conf.inc
index 2cd4d13..c1a205b 100644
--- a/tests/channels/pjsip/publish/presence_pidf/configs/ast1/modules.conf.inc
+++ b/tests/channels/pjsip/publish/presence_pidf/configs/ast1/modules.conf.inc
@@ -1 +1,2 @@
 noload => pbx_ael.so
+noload => pbx_lua.so
diff --git a/tests/channels/pjsip/publish/presence_xpidf/configs/ast1/modules.conf.inc b/tests/channels/pjsip/publish/presence_xpidf/configs/ast1/modules.conf.inc
index 2cd4d13..c1a205b 100644
--- a/tests/channels/pjsip/publish/presence_xpidf/configs/ast1/modules.conf.inc
+++ b/tests/channels/pjsip/publish/presence_xpidf/configs/ast1/modules.conf.inc
@@ -1 +1,2 @@
 noload => pbx_ael.so
+noload => pbx_lua.so

-- 
To view, visit https://gerrit.asterisk.org/10102
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 15.6
Gerrit-MessageType: merged
Gerrit-Change-Id: I7413184f13a0d85459d21d7ad701a83c13ba66f4
Gerrit-Change-Number: 10102
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180913/b246cdc5/attachment.html>


More information about the asterisk-code-review mailing list