[Asterisk-code-review] manager: Set AMI event "Newexten" to the EVENT FLAG DIALPLAN... (asterisk[16.0])

[George Joseph]

George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/10063 )

Change subject: manager: Set AMI event "Newexten" to the EVENT_FLAG_DIALPLAN class
......................................................................

manager: Set AMI event "Newexten" to the EVENT_FLAG_DIALPLAN class

The documentation already specified EVENT_FLAG_DIALPLAN for this
event, but the implementation was using EVENT_FLAG_CALL.

Using EVENT_FLAG_DIALPLAN allows AMI clients to opt out of receiving
this highly verbose event.

ASTERISK-28033

Change-Id: I45b3119f30e4dbc17b49831f2b1a4f2c1beadafe
---
M CHANGES
M UPGRADE.txt
M main/manager_channels.c
3 files changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Corey Farrell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  George Joseph: Approved for Submit



diff --git a/CHANGES b/CHANGES
index 783e2e6..fa177b5 100644
--- a/CHANGES
+++ b/CHANGES
@@ -64,6 +64,10 @@
    and ContactStatusDetail are now set to "NonQualified" when a contact exists
    but has not been qualified.
 
+ * The "Newexten" event is now part of the "dialplan" class. The documentation
+   for Asterisk 15 already specified this, but the implementation was actually
+   using the "call" class instead.
+
 ARI
 ------------------
  * The ContactInfo event's contact_status field is now set to "NonQualified"
diff --git a/UPGRADE.txt b/UPGRADE.txt
index 41e22c6..b2bd28d 100644
--- a/UPGRADE.txt
+++ b/UPGRADE.txt
@@ -41,6 +41,9 @@
    but has not been qualified.
  - The ContactStatus event will no longer be sent by PJSIP when a device
    refreshes its registration.
+ - The "Newexten" event is now part of the "dialplan" class. The documentation
+   for Asterisk 15 already specified this, but the implementation was actually
+   using the "call" class instead.
 
 ARI:
  - The ContactInfo event's contact_status field is now set to "NonQualified"
diff --git a/main/manager_channels.c b/main/manager_channels.c
index 37269a9..ac09d42 100644
--- a/main/manager_channels.c
+++ b/main/manager_channels.c
@@ -638,7 +638,7 @@
 
 	/* DEPRECATED: Extension field deprecated in 12; remove in 14 */
 	return ast_manager_event_blob_create(
-		EVENT_FLAG_CALL, "Newexten",
+		EVENT_FLAG_DIALPLAN, "Newexten",
 		"Extension: %s\r\n"
 		"Application: %s\r\n"
 		"AppData: %s\r\n",

-- 
To view, visit https://gerrit.asterisk.org/10063
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16.0
Gerrit-MessageType: merged
Gerrit-Change-Id: I45b3119f30e4dbc17b49831f2b1a4f2c1beadafe
Gerrit-Change-Number: 10063
Gerrit-PatchSet: 2
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180912/2cd92ed9/attachment.html>