[Asterisk-code-review] pjsip/dtmf info fallback: Test fails when connected line upd... (testsuite[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10084 )

Change subject: pjsip/dtmf_info_fallback: Test fails when connected line update is sent
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Should add app_dial as a test dependency in test-config.yaml as it uses the application.

https://gerrit.asterisk.org/#/c/10084/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10084/1//COMMIT_MSG@12
PS1, Line 12: This patch disables 'send_pai' since it's not needed for the test. Thus making
s/send_pai/send_rpid/


https://gerrit.asterisk.org/#/c/10084/1/tests/channels/pjsip/dtmf_info_fallback/configs/ast1/pjsip.conf
File tests/channels/pjsip/dtmf_info_fallback/configs/ast1/pjsip.conf:

https://gerrit.asterisk.org/#/c/10084/1/tests/channels/pjsip/dtmf_info_fallback/configs/ast1/pjsip.conf@a12
PS1, Line 12: 
I think you need to keep this setting.



-- 
To view, visit https://gerrit.asterisk.org/10084
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e11131e0200b073c22c9fe44bef49ba56d5d4e6
Gerrit-Change-Number: 10084
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 11 Sep 2018 22:24:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180911/099645fa/attachment.html>