[Asterisk-code-review] res pjsip: Log IPv6 addresses correctly (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10058 )

Change subject: res_pjsip: Log IPv6 addresses correctly
......................................................................


Patch Set 1: Code-Review-1

There are a few places where IPv6 logging is not fixed:
* res_pjsip_websocket.c:websocket_on_rx_msg() The debug message for both uri->host and rdata->pkt_info.src_name need to get the [] treatment.
* res_pjsip_outbound_authenticator_digest.c:digest_create_request_with_auth_from_old() creating the id value from challenge->pkt_info.src_name and port.  The id string is used for any subsequent error messages that happen.

This should be done for completeness:
In res_pjsip.c:ast_sip_create_rdata_with_contact() does not setup rdata->pkt_info.src_addr at all even though it sets .src_name.  We should get it setup for completeness just in case even though I don't think anything is going to use it.

Not much we can really do about this:
In pjproject itself sip_transport_loop.c does not setup rdata->pkt_info.src_addr to match .src_name.  Probably we don't really care since how often would that transport be needed? :)


-- 
To view, visit https://gerrit.asterisk.org/10058
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cfe997ced7883862a12b9c7d8551d76ae02fcf8
Gerrit-Change-Number: 10058
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 11 Sep 2018 22:04:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180911/d4631733/attachment-0001.html>