[Asterisk-code-review] syncami: wrap utf-8 string before parsing (testsuite[16])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10066 )

Change subject: syncami: wrap utf-8 string before parsing
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10066/1/lib/python/asterisk/syncami.py
File lib/python/asterisk/syncami.py:

https://gerrit.asterisk.org/#/c/10066/1/lib/python/asterisk/syncami.py@98
PS1, Line 98:         data = StringIO(res.read().decode('utf-8'))
We might want to use `.decode('utf-8', 'ignore')`, otherwise by default .decode will throw an exception if the stream contains any invalid utf-8 bytes.



-- 
To view, visit https://gerrit.asterisk.org/10066
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I24af2df707983accc9298da095c018b1aaf963e3
Gerrit-Change-Number: 10066
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Mon, 10 Sep 2018 17:28:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180910/fab65e28/attachment-0001.html>