[Asterisk-code-review] res pjproject: Add utility functions to convert between sock... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10013 )

Change subject: res_pjproject: Add utility functions to convert between socket structures
......................................................................


Patch Set 6:

it appears my compiler is upset now oddly enough:

res_pjproject.c: In function ‘ast_sockaddr_to_pj_sockaddr’:
res_pjproject.c:493:25: error: incompatible types when assigning to type ‘pj_in_addr {aka struct pj_in_addr}’ from type ‘struct in_addr’
   pjaddr->ipv4.sin_addr   = sin->sin_addr;
                         ^
res_pjproject.c: In function ‘ast_sockaddr_from_pj_sockaddr’:
res_pjproject.c:514:17: error: incompatible types when assigning to type ‘struct in_addr’ from type ‘pj_in_addr {aka const struct pj_in_addr}’
   sin->sin_addr   = pjaddr->ipv4.sin_addr;


-- 
To view, visit https://gerrit.asterisk.org/10013
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If0fc4bba9643f755604c6ffbb0d7cc46020bc761
Gerrit-Change-Number: 10013
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sun, 09 Sep 2018 12:30:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180909/202b8669/attachment.html>