[Asterisk-code-review] res musiconhold.c: Restart MOH if previous hold just reached... (asterisk[13])

[Frederic LE FOLL]

Frederic LE FOLL has posted comments on this change. ( https://gerrit.asterisk.org/10022 )

Change subject: res_musiconhold.c: Restart MOH if previous hold just reached end-of-file
......................................................................


Patch Set 2: Code-Review+1

Patch set 1 added a chance for two calls to ast_moh_files_next() only when ast_readframe() would fail because stream was not opened yet.
Patch set 2 is more tolerant because it offers a chance for two calls to ast_moh_files_next() regardless of the reason for the first ast_readframe() failure.
However, patch set 2 also addresses the MOH failure that we encountered (by the way, its probability after a previous Hold is (sample length / file length): higher probability when file is shorter).


-- 
To view, visit https://gerrit.asterisk.org/10022
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I1508cf2c094f8feca22d6f76deaa9fdfa9944860
Gerrit-Change-Number: 10022
Gerrit-PatchSet: 2
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 07 Sep 2018 06:57:40 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180907/833046b0/attachment.html>