[Asterisk-code-review] manager: Set AMI event "Newexten" to the EVENT FLAG DIALPLAN... (asterisk[15])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/10037 )

Change subject: manager: Set AMI event "Newexten" to the EVENT_FLAG_DIALPLAN class
......................................................................


Patch Set 2:

> Only putting the change in 16/master sounds fair to me.
 > 
 > I'd be happy to make the change but I'm not sure how to proceed.
 > Should the same note be made in both UPGRADE.txt and CHANGES?
 > 
 > And how to please Gerrit? Start with a cherry-pick to 16, amend
 > with an updated UPGRADE.txt then abandon this original version?

You can have the same note in both UPGRADE and CHANGES, that's perfectly fine. Personally, I would abandon the review against 15 and make the change on 16 and cherry pick to 16.0 and master from there, since it would be easier to keep up with locally, but feel free to take a different approach if you'd like!


-- 
To view, visit https://gerrit.asterisk.org/10037
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I45b3119f30e4dbc17b49831f2b1a4f2c1beadafe
Gerrit-Change-Number: 10037
Gerrit-PatchSet: 2
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: lvl <digium at lvlconsultancy.nl>
Gerrit-Comment-Date: Thu, 06 Sep 2018 22:18:26 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180906/3468e837/attachment-0001.html>