[Asterisk-code-review] core: Don't stop generators when writing RTCP frames. (asterisk[15])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10049 )

Change subject: core: Don't stop generators when writing RTCP frames.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10049/1/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/10049/1/main/channel.c@5054
PS1, Line 5054: if (ast_channel_generatordata(chan) && (!fr->src || strcasecmp(fr->src, "ast_prod")) && (fr->frametype != AST_FRAME_RTCP)) {
How about making this second so we can potentially avoid the strcasecmp?



-- 
To view, visit https://gerrit.asterisk.org/10049
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieadada07b068a7aa426e8763f1b73a18e1ac34a9
Gerrit-Change-Number: 10049
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 06 Sep 2018 21:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180906/d32a220f/attachment.html>