[Asterisk-code-review] manager: Set AMI event "Newexten" to the EVENT FLAG DIALPLAN... (asterisk[15])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/10037 )

Change subject: manager: Set AMI event "Newexten" to the EVENT_FLAG_DIALPLAN class
......................................................................


Patch Set 2:

> > The NewExten used to go out under the EVENT_FLAG_CALL
 > > classification.  However, the EVENT_FLAG_DIALPLAN was
 > specifically
 > > created in v1.6.0 for the extremely chatty VarSet and NewExten
 > > events to cut down on these nuisance events.
 > >
 > > When stasis was added it got incorrectly set to the
 > EVENT_FLAG_CALL
 > > classification even though it was documented for the
 > > EVENT_FLAG_DIALPLAN classification.  It has been this way since
 > > v12.0.0 was released.
 > >
 > > I think since it hasn't been reported earlier that nobody really
 > > cares that much about which event classification it comes from
 > and
 > > we should put it back into the right classification where it
 > > belongs.
 > 
 > I agree and think this patch should go into 16, 16.0 and master
 > (ensure that 16.0.0 uses EVENT_FLAG_DIALPLAN).  I think the
 > argument for and against putting it into 13 and 15 are valid.  If
 > we put this into 13/15 it needs to be mentioned in UPGRADE /
 > CHANGES files.

Ok, so I'd be ok with sliding this into 16, 16.0, and master with mention in UPGRADE/CHANGES but I don't feel comfortable with putting it into 13 or 15.  If someone would like to make this happen, I'd be ok with moving forward with this change.


-- 
To view, visit https://gerrit.asterisk.org/10037
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I45b3119f30e4dbc17b49831f2b1a4f2c1beadafe
Gerrit-Change-Number: 10037
Gerrit-PatchSet: 2
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 06 Sep 2018 18:36:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180906/3ff53a3e/attachment.html>