[Asterisk-code-review] core: Don't stop generators when writing RTCP frames. (asterisk[15])

Joshua Colp asteriskteam at digium.com
Thu Sep 6 04:13:57 CDT 2018


Joshua Colp has uploaded this change for review. ( https://gerrit.asterisk.org/10049


Change subject: core: Don't stop generators when writing RTCP frames.
......................................................................

core: Don't stop generators when writing RTCP frames.

Generators provide such functionality as tone generation or
silence generation. RTCP frames provide RTCP information and
should not stop generators from operating.

ASTERISK-28005

Change-Id: Ieadada07b068a7aa426e8763f1b73a18e1ac34a9
---
M main/channel.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/49/10049/1

diff --git a/main/channel.c b/main/channel.c
index 140d8e9..611e812 100644
--- a/main/channel.c
+++ b/main/channel.c
@@ -5051,7 +5051,7 @@
 		goto done;
 	}
 
-	if (ast_channel_generatordata(chan) && (!fr->src || strcasecmp(fr->src, "ast_prod"))) {
+	if (ast_channel_generatordata(chan) && (!fr->src || strcasecmp(fr->src, "ast_prod")) && (fr->frametype != AST_FRAME_RTCP)) {
 		if (ast_test_flag(ast_channel_flags(chan), AST_FLAG_WRITE_INT)) {
 				ast_deactivate_generator(chan);
 		} else {

-- 
To view, visit https://gerrit.asterisk.org/10049
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieadada07b068a7aa426e8763f1b73a18e1ac34a9
Gerrit-Change-Number: 10049
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180906/3659e3fb/attachment.html>


More information about the asterisk-code-review mailing list