[Asterisk-code-review] res pjsip: Add utility functions to convert between socket s... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10013 )

Change subject: res_pjsip: Add utility functions to convert between socket structures
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10013/2/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/10013/2/res/res_pjsip.c@4764
PS2, Line 4764: 	memset(pjaddr, 0, sizeof(*pjaddr));
I am not convinced that these memset()s are needed, so more research is needed here.


https://gerrit.asterisk.org/#/c/10013/2/res/res_pjsip.c@4785
PS2, Line 4785: 	memset(addr, 0, sizeof(*addr));
I am not convinced that these memset()s are needed, so more research is needed here.



-- 
To view, visit https://gerrit.asterisk.org/10013
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If0fc4bba9643f755604c6ffbb0d7cc46020bc761
Gerrit-Change-Number: 10013
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 04 Sep 2018 17:57:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180904/3be69b99/attachment.html>