[Asterisk-code-review] res pjsip: Add XML documentation for "use callerid contact" (asterisk[13])

Sean Bright asteriskteam at digium.com
Wed Oct 31 08:19:41 CDT 2018


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10574 )

Change subject: res_pjsip: Add XML documentation for "use_callerid_contact"
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10574/1/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/10574/1/res/res_pjsip.c@1832
PS1, Line 1832: 					<synopsis>Place callerid information into Contact header</synopsis>
s/callerid/Caller-ID/

(it's inconsistent throughout this file, but the block just above has it as 'caller-id')


https://gerrit.asterisk.org/#/c/10574/1/res/res_pjsip.c@1834
PS1, Line 1834: 						This option will cause Asterisk to place callerid information into
Samesies



-- 
To view, visit https://gerrit.asterisk.org/10574
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I69d48813ec514f5ef06c6de994cba52630e0a3b4
Gerrit-Change-Number: 10574
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:19:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181031/501c94c2/attachment.html>


More information about the asterisk-code-review mailing list