[Asterisk-code-review] res pjsip sdp rtp: Properly set packetization on the codec (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10495 )

Change subject: res_pjsip_sdp_rtp: Properly set packetization on the codec
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/10495/2/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/10495/2/res/res_pjsip_sdp_rtp.c@396
PS2, Line 396: 		if (codecs.framing) {
             : 			/* Copy the codecs framing ms even though there is no match */
             : 			ast_rtp_codecs_set_framing(ast_rtp_instance_get_codecs(session_media->rtp), codecs.framing);
             : 		}
> The problem as I see it is the framing is lost forever when the line following the if statement dest […]
This is not actually needed. Your SDP answer in the test was not correct, resulting in SDP negotiation rightfully failing. This change was working around that failure to make the test work.



-- 
To view, visit https://gerrit.asterisk.org/10495
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64b8fc6a140a93fbdb2f97550a40d0ff334e607
Gerrit-Change-Number: 10495
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Cripps <rcripps at voxbone.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Robert Cripps <rcripps at voxbone.com>
Gerrit-Comment-Date: Tue, 30 Oct 2018 14:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181030/31a7ccc4/attachment-0001.html>