[Asterisk-code-review] testsuite: Added tests for correct packetization (testsuite[13])

Joshua Colp asteriskteam at digium.com
Tue Oct 30 08:58:04 CDT 2018


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10557 )

Change subject: testsuite: Added tests for correct packetization
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/transcode/sipp/uas_asterisk.xml
File tests/channels/pjsip/rtp_ptime/transcode/sipp/uas_asterisk.xml:

https://gerrit.asterisk.org/#/c/10557/1/tests/channels/pjsip/rtp_ptime/transcode/sipp/uas_asterisk.xml@44
PS1, Line 44: m=audio 8000 RTP/AVP 8 103
            : a=rtpmap:0 PCMU/8000
This is incorrect.

You've declared a payload of 8 which is for alaw here. It should be 0 for ulaw.

What is happening is that the SDP is being negotiated as their answer being alaw, with our configuration being ulaw, so no joint capabilities are negotiated.



-- 
To view, visit https://gerrit.asterisk.org/10557
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I16cfb5805d2b96fdf5cdbc8f53a86522d1d251a7
Gerrit-Change-Number: 10557
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Cripps <rcripps at voxbone.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 30 Oct 2018 13:58:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181030/9ed75f4b/attachment.html>


More information about the asterisk-code-review mailing list