[Asterisk-code-review] testsuite: Fix failing SIP blind transfer tests. (testsuite[master])
Joshua Colp
asteriskteam at digium.com
Mon Oct 29 04:57:58 CDT 2018
Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/10549 )
Change subject: testsuite: Fix failing SIP blind transfer tests.
......................................................................
testsuite: Fix failing SIP blind transfer tests.
A recent change to pjproject caused pjsua to use TCP by default for
these tests instead of UDP. This change forces pjsua to not use TCP.
ASTERISK-28085 #close
Reported-by: Joshua C. Colp
Change-Id: Ice3a588e2c35e3bfcaf057976772e522af1e95f9
---
M tests/channels/SIP/sip_blind_transfer/callee_refer_only/run-test
M tests/channels/SIP/sip_blind_transfer/callee_refer_only/test-config.yaml
M tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/run-test
M tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/test-config.yaml
M tests/channels/SIP/sip_blind_transfer/caller_refer_only/run-test
M tests/channels/SIP/sip_blind_transfer/caller_refer_only/test-config.yaml
M tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/run-test
M tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/test-config.yaml
8 files changed, 24 insertions(+), 16 deletions(-)
Approvals:
Corey Farrell: Looks good to me, but someone else must approve
Joshua Colp: Looks good to me, approved; Approved for Submit
diff --git a/tests/channels/SIP/sip_blind_transfer/callee_refer_only/run-test b/tests/channels/SIP/sip_blind_transfer/callee_refer_only/run-test
index b5e56d2..f7da145 100755
--- a/tests/channels/SIP/sip_blind_transfer/callee_refer_only/run-test
+++ b/tests/channels/SIP/sip_blind_transfer/callee_refer_only/run-test
@@ -136,15 +136,18 @@
def start_processes(self):
logger.debug("Starting Processes")
self.pja = subprocess.Popen(['pjsua', '--local-port=5065',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
self.pjb = subprocess.Popen(['pjsua', '--local-port=5066',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
self.pjc = subprocess.Popen(['pjsua', '--local-port=5067',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
diff --git a/tests/channels/SIP/sip_blind_transfer/callee_refer_only/test-config.yaml b/tests/channels/SIP/sip_blind_transfer/callee_refer_only/test-config.yaml
index 5d59ae2..a751bc2 100644
--- a/tests/channels/SIP/sip_blind_transfer/callee_refer_only/test-config.yaml
+++ b/tests/channels/SIP/sip_blind_transfer/callee_refer_only/test-config.yaml
@@ -1,5 +1,4 @@
testinfo:
- skip: 'See ASTERISK-28085'
summary: 'Test SIP Blind Transfer (callee transfers)'
description: |
This test verifies a SIP Blind transfer in which
diff --git a/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/run-test b/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/run-test
index daf7474..3ad650d 100755
--- a/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/run-test
+++ b/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/run-test
@@ -138,15 +138,18 @@
def start_processes(self):
logger.debug("Starting Processes")
self.pja = subprocess.Popen(['pjsua', '--local-port=5065',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
self.pjb = subprocess.Popen(['pjsua', '--local-port=5066',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
self.pjc = subprocess.Popen(['pjsua', '--local-port=5067',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
diff --git a/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/test-config.yaml b/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/test-config.yaml
index fed5922..8a25e9a 100644
--- a/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/test-config.yaml
+++ b/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/test-config.yaml
@@ -1,5 +1,4 @@
testinfo:
- skip: 'See ASTERISK-28085'
summary: 'Test SIP Blind Transfer (callee transfers with hold)'
description: |
This test verifies a SIP Blind transfer in which
diff --git a/tests/channels/SIP/sip_blind_transfer/caller_refer_only/run-test b/tests/channels/SIP/sip_blind_transfer/caller_refer_only/run-test
index 19dbfd7..0ff23a4 100755
--- a/tests/channels/SIP/sip_blind_transfer/caller_refer_only/run-test
+++ b/tests/channels/SIP/sip_blind_transfer/caller_refer_only/run-test
@@ -139,15 +139,18 @@
def start_processes(self):
logger.debug("Starting Processes")
self.pja = subprocess.Popen(['pjsua', '--local-port=5065',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
self.pjb = subprocess.Popen(['pjsua', '--local-port=5066',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
self.pjc = subprocess.Popen(['pjsua', '--local-port=5067',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
diff --git a/tests/channels/SIP/sip_blind_transfer/caller_refer_only/test-config.yaml b/tests/channels/SIP/sip_blind_transfer/caller_refer_only/test-config.yaml
index f42d8cf..f4c608b 100644
--- a/tests/channels/SIP/sip_blind_transfer/caller_refer_only/test-config.yaml
+++ b/tests/channels/SIP/sip_blind_transfer/caller_refer_only/test-config.yaml
@@ -1,5 +1,4 @@
testinfo:
- skip: 'See ASTERISK-28085'
summary: 'Test SIP Blind Transfer (caller transfers)'
description: |
This test verifies a SIP Blind transfer in which
diff --git a/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/run-test b/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/run-test
index 880ab88..0731eba 100755
--- a/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/run-test
+++ b/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/run-test
@@ -144,15 +144,18 @@
def start_processes(self):
logger.debug("Starting Processes")
self.pja = subprocess.Popen(['pjsua', '--local-port=5065',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
self.pjb = subprocess.Popen(['pjsua', '--local-port=5066',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
self.pjc = subprocess.Popen(['pjsua', '--local-port=5067',
- '--auto-answer=200', '--null-audio'],
+ '--auto-answer=200', '--null-audio',
+ '--no-tcp'],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
diff --git a/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/test-config.yaml b/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/test-config.yaml
index 0092225..e93443c 100644
--- a/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/test-config.yaml
+++ b/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/test-config.yaml
@@ -1,5 +1,4 @@
testinfo:
- skip: 'See ASTERISK-28085'
summary: 'Test SIP Blind Transfer (caller transfers with hold)'
description: |
This test verifies a SIP Blind transfer in which
--
To view, visit https://gerrit.asterisk.org/10549
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice3a588e2c35e3bfcaf057976772e522af1e95f9
Gerrit-Change-Number: 10549
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181029/d85b148f/attachment-0001.html>
More information about the asterisk-code-review
mailing list