[Asterisk-code-review] res pjsip notify: improve realtime performance on CLI comple... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10550 )

Change subject: res_pjsip_notify: improve realtime performance on CLI completion on the endpoint
......................................................................


Patch Set 1:

(1 comment)

Switching to ast_cli_completion_add is a good idea, just a couple nits I think are worth addressing.

https://gerrit.asterisk.org/#/c/10550/1/res/res_pjsip_notify.c
File res/res_pjsip_notify.c:

https://gerrit.asterisk.org/#/c/10550/1/res/res_pjsip_notify.c@897
PS1, Line 897: 		ast_sorcery_retrieve_by_prefix(ast_sip_get_sorcery(),
While you are here why not eliminate the RAII_VAR, just explicitly ao2_ref(endpoints, -1) at the end of the function?

In addition I think this function should check for endpoints != NULL before ao2_iterator_init.  You'll have to split the declaration and initialization of i.



-- 
To view, visit https://gerrit.asterisk.org/10550
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20024912cc77bf4d3e476c4cd853293c52b254b
Gerrit-Change-Number: 10550
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Fri, 26 Oct 2018 21:32:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181026/69adf72a/attachment.html>