[Asterisk-code-review] pjsip: new endpoint's options to control Connected Line updates (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10480 )

Change subject: pjsip: new endpoint's options to control Connected Line updates
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10480/2/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/#/c/10480/2/include/asterisk/res_pjsip.h@565
PS2, Line 565: 	/*! Do we accept connected line updates from this endpoint? */
             : 	unsigned int trust_connected_line;
             : 	/*! Do we send connected line updates to this endpoint? */
             : 	unsigned int send_connected_line;
> This is the correct spot for the master version only.  However, for
 > released versions, adding these parameters here breaks ABI
 > compatibility.  For released versions, these must go at the end of
 > the struct ast_sip_endpoint.

I said in the MASTER ONLY patch where you had declared the new options was the correct place for them.

In RELEASED branches they MUST go at the end of struct ast_sip_endpoint to not break ABI compatibility.  They cannot go in THIS structure on released branches because they shift everything in the encapsulating struct.  The encapsulating struct is ast_sip_endpoint.

There needs to be two versions of the patch.  One for the master branch and the other for the released branches.



-- 
To view, visit https://gerrit.asterisk.org/10480
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I16af967815efd904597ec2f033337e4333d097cd
Gerrit-Change-Number: 10480
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 22 Oct 2018 16:00:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181022/54362034/attachment.html>