[Asterisk-code-review] stasis: Add internal filtering of messages. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Thu Oct 18 08:35:46 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10479 )

Change subject: stasis: Add internal filtering of messages.
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/10479/4/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/10479/4/main/stasis.c@643
PS4, Line 643: 	ast_assert(type != NULL);
Should we have type == NULL cause accepted_message_types to be cleared (AST_VECTOR_RESET)?

Not a big deal since nothing calls this function.



-- 
To view, visit https://gerrit.asterisk.org/10479
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99bee23895baa0a117985d51683f7963b77aa190
Gerrit-Change-Number: 10479
Gerrit-PatchSet: 4
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 18 Oct 2018 13:35:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181018/52395bc7/attachment-0001.html>


More information about the asterisk-code-review mailing list