[Asterisk-code-review] bridges: Remove reliance on stasis caching (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10227 )

Change subject: bridges:  Remove reliance on stasis caching
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.asterisk.org/#/c/10227/5/main/Makefile
File main/Makefile:

https://gerrit.asterisk.org/#/c/10227/5/main/Makefile@170
PS5, Line 170: stasis.o: _ASTCFLAGS+=$(call get_menuselect_cflags,AO2_DEBUG)
> > This needs to be done in the 16 branch too.  It is not necessary in […]
The change in this makefile needs to be done in 16.  stasis.c has the AO2_DEBUG conditional code in it that will never be enabled if you enable AO2_DEBUG without this change.


https://gerrit.asterisk.org/#/c/10227/5/main/stasis_bridges.c
File main/stasis_bridges.c:

https://gerrit.asterisk.org/#/c/10227/5/main/stasis_bridges.c@333
PS5, Line 333: 	 * and use it in the update message.  It's possible though that the
             : 	 * bridge is shutting down before any snapshot was previously written
             : 	 * to the cache.  In this case, we need to create one from the current
> > The only reason it won't be in the cache when we are destroying the […]
I was pointing out that the highlighted statement is incorrect.  It is impossible for the snapshot to not be in the cache before the bridge shuts down unless linking it into the cache container failed.


https://gerrit.asterisk.org/#/c/10227/5/res/stasis/app.c
File res/stasis/app.c:

https://gerrit.asterisk.org/#/c/10227/5/res/stasis/app.c@181
PS5, Line 181: 	if (bridge) {
             : 		forwards->topic_forward = stasis_forward_all(ast_bridge_topic(bridge),
             : 			app->topic);
             : 	}
> > We used to forward all cached bridge events if we didn't have a […]
I have now back tracked who wants to see all bridge events.  The ARI user can request to subscribe to all events with the "subscribeAll" parameter when he opens the websocket.  He will not be able to get all of the bridge events without fixing this finding.



-- 
To view, visit https://gerrit.asterisk.org/10227
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7049b80efa88676ce5c4666f818fa18ad1985369
Gerrit-Change-Number: 10227
Gerrit-PatchSet: 5
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 17 Oct 2018 16:56:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181017/d0750d5d/attachment.html>