[Asterisk-code-review] res pjsip outbound registration: Adding Cause field value to... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10492 )

Change subject: res_pjsip_outbound_registration: Adding Cause field value to AMI event Registry
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10492/1/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/#/c/10492/1/res/res_pjsip_outbound_registration.c@1021
PS1, Line 1021: 		reason_hdr = pjsip_msg_find_hdr_by_name(response->rdata->msg_info.msg, &str_reason, NULL);
              : 		if (reason_hdr) {
              : 			pj_strdup_with_null(response->rdata->tp_info.pool, &reason_value, &reason_hdr->hvalue);
              : 			reason = pj_strbuf(&reason_value);
              : 		}
There can be more than one Reason header.  The code needs to take that into account since I think you want the Reason header with the Q.850 reason.

See res_pjsip_rfc3326.c:rfc3326_add_reason_header()



-- 
To view, visit https://gerrit.asterisk.org/10492
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I52d5176d9449d657ad3d33c1437f800c6318dc7b
Gerrit-Change-Number: 10492
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitriy Serov <serov.d.p at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:19:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181017/a4b5b15d/attachment.html>