[Asterisk-code-review] taskprocessor: Warn on unused result from pushing task. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Wed Oct 17 08:15:57 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10486 )

Change subject: taskprocessor: Warn on unused result from pushing task.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/10486/1/tests/test_threadpool.c
File tests/test_threadpool.c:

https://gerrit.asterisk.org/#/c/10486/1/tests/test_threadpool.c@333
PS1, Line 333: 
> Also tld.
Apparently the fields of tld are cleaned by test_shutdown.  I didn't catch this because apparently it's not an error on Fedora 28 but it is a deadlock for CentOS 7.



-- 
To view, visit https://gerrit.asterisk.org/10486
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4079bd7b21cfe52fb431ea79e41314520c3f6d
Gerrit-Change-Number: 10486
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181017/2e6d5388/attachment.html>


More information about the asterisk-code-review mailing list