[Asterisk-code-review] res pjsip sdp rtp: Control endpoints media address use per c... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10431 )

Change subject: res_pjsip_sdp_rtp: Control endpoints media_address use per call basis
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

This is a new feature so it should also have a test to confirm that the dialplan variable does as it should and doesn't break in the future. If no test is provided then it would be eligible for master.

https://gerrit.asterisk.org/#/c/10431/7/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/10431/7/res/res_pjsip_sdp_rtp.c@1249
PS7, Line 1249: 		const char *use_media_address = pbx_builtin_getvar_helper(session->channel, "PJSIP_USE_MEDIA_ADDRESS");
This needs to be documented somewhere. The sample configuration file as well as the XML documentation for media_address in res_pjsip.c I think, otherwise noone will know it exists.

It should also go into the CHANGES file.


https://gerrit.asterisk.org/#/c/10431/7/res/res_pjsip_sdp_rtp.c@1251
PS7, Line 1251: 		if (!ast_strlen_zero(use_media_address) && !strcmp("no", use_media_address)) {
Instead of using "no" this should use ast_false so it is consistent with other yes/no options.



-- 
To view, visit https://gerrit.asterisk.org/10431
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I852adbee9f8b034ec332fbe4e1b6692cb2939518
Gerrit-Change-Number: 10431
Gerrit-PatchSet: 7
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 17 Oct 2018 10:15:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181017/42d09810/attachment.html>