[Asterisk-code-review] taskprocessor: Warn on unused result from pushing task. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Wed Oct 17 04:47:48 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10486 )

Change subject: taskprocessor: Warn on unused result from pushing task.
......................................................................


Patch Set 2:

Now that I've cherry-picked to the branches I'm realizing this is a gray area for API breakage.  Technically the changes to the headers could cause existing 3rd-party code to not compile.  On the other hand it is almost always a bug to not check the result of these functions.

So the fixes associated with this change apply to 13/16, if wanted I can revert the header changes.

Also I'm not sure what the test failure is all about.  It's not failing locally and I'm not seeing any useful information from jenkins.


-- 
To view, visit https://gerrit.asterisk.org/10486
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4079bd7b21cfe52fb431ea79e41314520c3f6d
Gerrit-Change-Number: 10486
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 17 Oct 2018 09:47:48 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181017/6d8dc773/attachment.html>


More information about the asterisk-code-review mailing list