[Asterisk-code-review] app dial/queue/followme: 'I' options to block initial update... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10286 )

Change subject: app_dial/queue/followme: 'I' options to block initial updates in both directions
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10286/3/apps/app_dial.c
File apps/app_dial.c:

https://gerrit.asterisk.org/#/c/10286/3/apps/app_dial.c@1332
PS3, Line 1332: 				if (o->pending_connected_update && !ast_test_flag64(o, OPT_IGNORE_CONNECTEDLINE)) {
Revert this.

This change is not necessary as o->pending_connected_update will not be set if the OPT_IGNORE_CONNECTEDLINE flag is true.  See around line 1529 where the only place the flag is set true by an AST_CONTROL_CONNECTED_LINE from a called channel.


https://gerrit.asterisk.org/#/c/10286/3/apps/app_queue.c
File apps/app_queue.c:

https://gerrit.asterisk.org/#/c/10286/3/apps/app_queue.c@4934
PS3, Line 4934: 						if (o->pending_connected_update && !o->block_connected_update) {
Revert this for the same reason as app_dial.  See AST_CONTROL_CONNECTED_LINE around line 5107.



-- 
To view, visit https://gerrit.asterisk.org/10286
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ce9e151a2220ce9e95aa66666933cfb9e2a4a01
Gerrit-Change-Number: 10286
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 22:03:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181016/2278ab1e/attachment.html>