[Asterisk-code-review] pjsip: new endpoint's options to control Connected Line updates (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/10480 )

Change subject: pjsip: new endpoint's options to control Connected Line updates
......................................................................


Patch Set 1:

> Good grief.  This patch is basically duplicating existing options.
 > send_connected_line is send_pai/send_rpid
 > trust_connected_line is trust_id_inbound/trust_id_outbound
 > 
 > WHY IS THIS PATCH EVEN NEEDED.

Disabling send_pai/send_rpid prevents PAI/RPID to be sent on the initial INVITE.
There are carriers which expect to receive PAI on all calls. If PAI is missing the calls are rejected.
But these carriers should not received Connected Line updates.
With new option 'send_connected_line' it's very simple...
carrier PJSIP endpoint should have:
send_rpid=yes
send_connected_line=no

And the same with incoming Connected Line updates.
There are carriers which indicate real CLID using PAI,
but we don't want to accept Connect Line updates.
With new option 'trust_connected_line'
PJSIP endpoint should have:
trust_id_inbound=yes
trust_connected_line=no

P.S.
This is a very simple and clear patch.
It does not break any functionality,
but only helps to solve problems with Connected Line updates very easily.


-- 
To view, visit https://gerrit.asterisk.org/10480
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I16af967815efd904597ec2f033337e4333d097cd
Gerrit-Change-Number: 10480
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 15:05:49 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181016/85fdcd9b/attachment-0001.html>