[Asterisk-code-review] app dial/queue/followme: 'I' options to block initial update... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10286 )

Change subject: app_dial/queue/followme: 'I' options to block initial updates in both directions
......................................................................


Patch Set 3:

> One more small issue...
 > 
 > The interception routine is called twice on initial request if the
 > Dial() is with only one destination.
 > 
 > This is because wait_for_answer() in the beginning
 > if (single) calls
 > update_connected_line_from_peer(in, outgoing->chan, 1);
 > then second time on AST_CONTROL_CONNECTED_LINE
 > 
 > I think the 1st update should be eliminated.
 > What do you think?

The first is for the Dial's configured caller-id or best guess taken from the called channel.  There is a lot of ancient history involved with why Dial does things (and some things that don't exactly make sense).  Messing with the that behavior in a released branch is likely to break something.  The second is from something further down the called channel's chain before the called channel is answered.  Neither can be eliminated.  Not all channel drivers generate connected line updates when their channels get answered.

You should know by now that connected line updates get triggered for various reasons and suppressing them is usually a bad idea.  There is code to suppress redundant connected line updates in the core. See channel.c:indicate_connected_line().  The suppression can only happen after the interception routines have had their say.


-- 
To view, visit https://gerrit.asterisk.org/10286
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ce9e151a2220ce9e95aa66666933cfb9e2a4a01
Gerrit-Change-Number: 10286
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 00:21:15 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181015/ad81a0c7/attachment-0001.html>