[Asterisk-code-review] refdebug: Create refstats.py script. (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10457 )

Change subject: refdebug: Create refstats.py script.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10457/1/main/astobj2.c
File main/astobj2.c:

https://gerrit.asterisk.org/#/c/10457/1/main/astobj2.c@67
PS1, Line 67: 	uint32_t lockused:1;
Good thing all the other bits are constant and this bit is only set.  Otherwise we would have reentrancy issues because changing this bit is not protected.

This bit now precludes any other bits from being stolen from the magic number unless they are also constant after object creation.  Basically only the options field can get larger.

I think a comment describing the above and indicating the bits involved for the uint32_t is in order.



-- 
To view, visit https://gerrit.asterisk.org/10457
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e9d679cc86d772cc97c888d9d856a17e0d3a4a
Gerrit-Change-Number: 10457
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 23:59:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181012/d7c2abcc/attachment.html>