[Asterisk-code-review] bridges: Remove reliance on stasis caching (asterisk[master])

Corey Farrell asteriskteam at digium.com
Tue Oct 9 05:59:10 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10227 )

Change subject: bridges:  Remove reliance on stasis caching
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/10227/5/main/Makefile
File main/Makefile:

https://gerrit.asterisk.org/#/c/10227/5/main/Makefile@170
PS5, Line 170: stasis.o: _ASTCFLAGS+=$(call get_menuselect_cflags,AO2_DEBUG)
> This needs to be done in the 16 branch too.  It is not necessary in the 16.0 branch. […]
AO2_DEBUG is checked to avoid unnecessary construction of the container names.  I'm thinking this could be handled by creating a new ao2 function to support run-time check for AO2_DEBUG:
int ao2_debug_enabled(void);



-- 
To view, visit https://gerrit.asterisk.org/10227
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7049b80efa88676ce5c4666f818fa18ad1985369
Gerrit-Change-Number: 10227
Gerrit-PatchSet: 5
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 10:59:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181009/a76ee92f/attachment.html>


More information about the asterisk-code-review mailing list