[Asterisk-code-review] loader: Perform chained starts when missing dependencies are... (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10447 )

Change subject: loader: Perform chained starts when missing dependencies are started.
......................................................................


Patch Set 1:

I tested this patch by making res_statsd.c decline on missing config and deleting statsd.conf.  This caused res_pjsip* to decline at startup, 'module show' listed all pjsip modules as not running.  I then restored statsd.conf, typed 'module load res_statsd'.  After this 'module show' listed all pjsip modules as running.

I think this needs to do better about reporting status to CLI.  cli.c prints "Loaded %s\n" for the requested module upon return from ast_load_resource.  ast_load_resource is unaware of the CLI FD and cli.c is unaware of the chained startups so I'm not sure how to deal with this.


-- 
To view, visit https://gerrit.asterisk.org/10447
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cfe77a550a036b549ff5c47c05f69eead61f5e3
Gerrit-Change-Number: 10447
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 09:06:54 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181009/c5248c55/attachment-0001.html>