[Asterisk-code-review] codec speex.c: Cleanup module loading to DECLINE and not FAI... (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10436 )

Change subject: codec_speex.c: Cleanup module loading to DECLINE and not FAILURE.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/10436/1/codecs/codec_speex.c
File codecs/codec_speex.c:

https://gerrit.asterisk.org/#/c/10436/1/codecs/codec_speex.c@692
PS1, Line 692: 	ast_unregister_translator(&speextolin);
Same comment as I made about the custom function unregister, seems pointless for this unregister function to return errors.



-- 
To view, visit https://gerrit.asterisk.org/10436
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia262591f68333dad17673ba7104d11c88096f51a
Gerrit-Change-Number: 10436
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Thu, 04 Oct 2018 23:52:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181004/edf6155c/attachment.html>