[Asterisk-code-review] func periodic hook.c: Cleanup module resources on failure. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10439 )

Change subject: func_periodic_hook.c: Cleanup module resources on failure.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/10439/1/funcs/func_periodic_hook.c
File funcs/func_periodic_hook.c:

https://gerrit.asterisk.org/#/c/10439/1/funcs/func_periodic_hook.c@449
PS1, Line 449: 	ast_custom_function_unregister(&hook_function);
Maybe in master we should just remove the return value from ast_custom_function_unregister or have it unconditionally return 0?  Seems likely that it's always a mistake for the caller to handle an error from this function.



-- 
To view, visit https://gerrit.asterisk.org/10439
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I280fc6e8ba2a7ee2588ca01d870eebaf74b4ffe6
Gerrit-Change-Number: 10439
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Thu, 04 Oct 2018 23:48:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181004/463ec414/attachment.html>