[Asterisk-code-review] CI: Use brace expansion instead of calling out to seq (asterisk[master])

George Joseph asteriskteam at digium.com
Thu Oct 4 09:41:49 CDT 2018


George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/10406 )

Change subject: CI: Use brace expansion instead of calling out to seq
......................................................................

CI: Use brace expansion instead of calling out to seq

Also make the shebang in publishAsteriskDocs.sh the first line.

Change-Id: I3fdd6f22e652e4fb5b5fe85df46fa34eb6d0cf08
---
M tests/CI/publishAsteriskDocs.sh
M tests/CI/runUnittests.sh
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/tests/CI/publishAsteriskDocs.sh b/tests/CI/publishAsteriskDocs.sh
index d5c857a..dc59033 100755
--- a/tests/CI/publishAsteriskDocs.sh
+++ b/tests/CI/publishAsteriskDocs.sh
@@ -1,7 +1,7 @@
+#!/usr/bin/env bash
 #
 # Publish Asterisk documentation to the wiki
 #
-#!/usr/bin/env bash
 CIDIR=$(dirname $(readlink -fn $0))
 source $CIDIR/ci.functions
 ASTETCDIR=$DESTDIR/etc/asterisk
@@ -113,7 +113,7 @@
 rm -f ${OUTPUTDIR}/full-en_US.xml
 
 sudo $ASTERISK ${USER_GROUP:+-U ${USER_GROUP%%:*} -G ${USER_GROUP##*:}} -gn -C $CONFFILE
-for n in `seq 1 5` ; do
+for n in {1..5} ; do
 	sleep 3
 	$ASTERISK -rx "core waitfullybooted" -C $CONFFILE && break
 done
diff --git a/tests/CI/runUnittests.sh b/tests/CI/runUnittests.sh
index 1d2656b..d451362 100755
--- a/tests/CI/runUnittests.sh
+++ b/tests/CI/runUnittests.sh
@@ -55,7 +55,7 @@
 
 set -x
 sudo $ASTERISK ${USER_GROUP:+-U ${USER_GROUP%%:*} -G ${USER_GROUP##*:}} -gn -C $CONFFILE
-for n in `seq 1 5` ; do
+for n in {1..5} ; do
 	sleep 3
 	$ASTERISK -rx "core waitfullybooted" -C $CONFFILE && break
 done

-- 
To view, visit https://gerrit.asterisk.org/10406
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fdd6f22e652e4fb5b5fe85df46fa34eb6d0cf08
Gerrit-Change-Number: 10406
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181004/730a84cf/attachment.html>


More information about the asterisk-code-review mailing list