[Asterisk-code-review] Test unittests crash. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Wed Oct 3 14:20:08 CDT 2018


Corey Farrell has uploaded this change for review. ( https://gerrit.asterisk.org/10411


Change subject: Test unittests crash.
......................................................................

Test unittests crash.

This is being posted to test that a crash will produce backtrace in
jenkins artifacts.  One jenkins runs this will be abandoned.

Change-Id: If8292d450bd9de4e09d03fbbf9c2f451916d334a
---
M main/asterisk.c
M tests/CI/runUnittests.sh
2 files changed, 18 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/11/10411/1

diff --git a/main/asterisk.c b/main/asterisk.c
index 1d52567..ea9edf2 100644
--- a/main/asterisk.c
+++ b/main/asterisk.c
@@ -4154,6 +4154,9 @@
 
 	ast_stun_init();
 
+	/* Cause a crash for testing. */
+	ast_free(ao2_alloc(1, NULL));
+
 	dnsmgr_start_refresh();
 
 	if (ast_opt_no_fork) {
diff --git a/tests/CI/runUnittests.sh b/tests/CI/runUnittests.sh
index 1d2656b..cb4bb88 100755
--- a/tests/CI/runUnittests.sh
+++ b/tests/CI/runUnittests.sh
@@ -3,6 +3,17 @@
 source $CIDIR/ci.functions
 ASTETCDIR=$DESTDIR/etc/asterisk
 
+asterisk_core_base() {
+	local pattern=$(/sbin/sysctl -n kernel.core_pattern)
+
+	# If core_pattern is a pipe there isn't much we can do
+	if [[ ${pattern:0:1} == "|" ]] ; then
+		echo "core*"
+	else
+		echo "${pattern%%%*}*"
+	fi
+}
+
 cat <<-EOF > "$ASTETCDIR/logger.conf"
 	[logfiles]
 	full => notice,warning,error,debug,verbose
@@ -69,8 +80,10 @@
 set +x
 
 [ x"$USER_GROUP" != x ] && sudo chown -R $USER_GROUP $OUTPUTDIR
-if [ -f core* ] ; then
+
+corepatt=$(asterisk_core_base)
+if [ -f $corepatt ] ; then
 	echo "*** Found a core file after running unit tests ***"
-	$DESTDIR/var/lib/asterisk/scripts/ast_coredumper --no-default-search core*
+	sudo OUTPUTDIR=$OUTPUTDIR $DESTDIR/var/lib/asterisk/scripts/ast_coredumper --no-default-search $corepatt
 	exit 1
 fi

-- 
To view, visit https://gerrit.asterisk.org/10411
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8292d450bd9de4e09d03fbbf9c2f451916d334a
Gerrit-Change-Number: 10411
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181003/e1065436/attachment.html>


More information about the asterisk-code-review mailing list