[Asterisk-code-review] RFC: Add support for disabled modules. (asterisk[master])

George Joseph asteriskteam at digium.com
Wed Oct 3 14:10:41 CDT 2018


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10377 )

Change subject: RFC: Add support for disabled modules.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10377/1/include/asterisk/module.h
File include/asterisk/module.h:

https://gerrit.asterisk.org/#/c/10377/1/include/asterisk/module.h@109
PS1, Line 109: 	 * should be used instead.
I'd add an explicit note that asterisk will terminate if any module returns this status.



-- 
To view, visit https://gerrit.asterisk.org/10377
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic44810ca6ce3deca30bceeb4eaa306d94f6b90e8
Gerrit-Change-Number: 10377
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Wed, 03 Oct 2018 19:10:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181003/f73b518e/attachment.html>


More information about the asterisk-code-review mailing list