[Asterisk-code-review] res statsd.c: Made use defaults if the statsd.conf file does... (asterisk[16])

Richard Mudgett asteriskteam at digium.com
Wed Oct 3 07:44:56 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10385 )

Change subject: res_statsd.c: Made use defaults if the statsd.conf file does not exist.
......................................................................


Patch Set 1:

> As with smdi, I'd like to understand if this should be the new
 > default behavior for all modules.

It is really up to the module how it wants to behave.  Of course you could go and change all other modules to have this behavior.  However, I think doing such a mass change brings little benefit.  The statsd and smdi modules are just a current pain point because they are optional use modules.


-- 
To view, visit https://gerrit.asterisk.org/10385
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: If1068a582ec54ab7fb437265cb5370a97a825737
Gerrit-Change-Number: 10385
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 03 Oct 2018 12:44:56 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181003/b1e023d6/attachment.html>


More information about the asterisk-code-review mailing list