[Asterisk-code-review] core: Disable astobj2 locking for some common objects. (asterisk[master])
Corey Farrell
asteriskteam at digium.com
Tue Oct 2 14:59:30 CDT 2018
Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10378 )
Change subject: core: Disable astobj2 locking for some common objects.
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/10378/1/include/asterisk/astobj2.h
File include/asterisk/astobj2.h:
https://gerrit.asterisk.org/#/c/10378/1/include/asterisk/astobj2.h@408
PS1, Line 408: #define ao2_alloc_nolock(data_size, destructor_fn) \
: __ao2_alloc((data_size), (destructor_fn), AO2_ALLOC_OPT_LOCK_NOLOCK, "", __FILE__, __LINE__, __PRETTY_FUNCTION__)
: #define ao2_t_alloc_nolock(data_size, destructor_fn, tag) \
: __ao2_alloc((data_size), (destructor_fn), AO2_ALLOC_OPT_LOCK_NOLOCK, (tag), __FILE__, __LINE__, __PRETTY_FUNCTION__)
> What's wrong with using ao2_alloc_options() ?? […]
The allocator options are so long that it always requires wrapping the arguments. I can remove this if you feel strongly but I think it improves readability of callers.
--
To view, visit https://gerrit.asterisk.org/10378
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie999b9941760be3d1946cdb6e30cb85fd97504d8
Gerrit-Change-Number: 10378
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 19:59:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181002/ebd29d8a/attachment.html>
More information about the asterisk-code-review
mailing list