[Asterisk-code-review] astobj2: Assert on attempt to lock object with no locking. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10376 )

Change subject: astobj2: Assert on attempt to lock object with no locking.
......................................................................


Patch Set 1: Code-Review-1

I'm not in favor of this.  You currently don't need to care what locking mechanism is on an object to lock/unlock it.  The only exception is for recursively locking an object because rwlocks are not recursive.

You could create the same type of object but with different locking mechanisms if you want.


-- 
To view, visit https://gerrit.asterisk.org/10376
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5518e55739769792a76f766ce25880d7d944f63b
Gerrit-Change-Number: 10376
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 18:54:56 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181002/6c52b48b/attachment.html>