[Asterisk-code-review] core/frame: correct ast frdup() and ast frisolate() in case ... (asterisk[13])

Emmanuel BUU asteriskteam at digium.com
Tue Oct 2 03:18:59 CDT 2018


Hello Richard Mudgett, Kevin Harwell, Jenkins2, Corey Farrell, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10269

to look at the new patch set (#3).

Change subject: core/frame: correct ast_frdup() and ast_frisolate() in case of empty text frame
......................................................................

core/frame: correct ast_frdup() and ast_frisolate() in case of empty text frame

If a channel creates a AST_TEXT_FRAME with datalen == 0, the ast_frdup()
and the ast_frisolate() would create a clone with and an invalid data.ptr.
It would causes a crash. The proposed fix is to make sure that for such empty
text frames,  ast_frdup() and ast_frisolate() return cloned text frames with
a valid  data.ptr.

ASTERISK-28076
Reported by: Emmanuel BUU
Tested by: Emmanuel BUU

Change-Id: Ib882dd028598f13c4c233edbfdd7e54ad44a68e9
---
M main/frame.c
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/69/10269/3
-- 
To view, visit https://gerrit.asterisk.org/10269
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib882dd028598f13c4c233edbfdd7e54ad44a68e9
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 3
Gerrit-Owner: Emmanuel BUU <emmanuel.buu at ives.fr>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181002/cb890918/attachment.html>


More information about the asterisk-code-review mailing list