[Asterisk-code-review] astobj2: Record lock usage to refs log when DEBUG THREADS is... (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Mon Oct 1 17:26:28 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10347 )

Change subject: astobj2: Record lock usage to refs log when DEBUG_THREADS is enabled.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10347/1/contrib/scripts/reflocks.py
File contrib/scripts/reflocks.py:

https://gerrit.asterisk.org/#/c/10347/1/contrib/scripts/reflocks.py@28
PS1, Line 28: def parse_line(line):
This function isn't used


https://gerrit.asterisk.org/#/c/10347/1/contrib/scripts/reflocks.py@63
PS1, Line 63:             tokens = line.strip().split(',', 7)
A comment about what the token indices mean would be nice since the process_line function is not used and should be removed.



-- 
To view, visit https://gerrit.asterisk.org/10347
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e3cd23336a97df2692b545f548fd79b14b53bf4
Gerrit-Change-Number: 10347
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 01 Oct 2018 22:26:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181001/54780b06/attachment-0001.html>


More information about the asterisk-code-review mailing list