[Asterisk-code-review] bridges: Remove reliance on stasis caching (asterisk[master])

George Joseph asteriskteam at digium.com
Mon Oct 1 09:39:18 CDT 2018


Hello Kevin Harwell, Jenkins2, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10227

to look at the new patch set (#5).

Change subject: bridges:  Remove reliance on stasis caching
......................................................................

bridges:  Remove reliance on stasis caching

* The bridging core no longer uses the stasis cache for bridge
  snapshots.  Bridge snapshots are now stored in an rbtree
  container in stasis_bridges.c

* The following APIs are no longer available since the stasis cache
  is no longer used:
    ast_bridge_topic_cached()
    ast_bridge_topic_all_cached()

* A topic pool is now used for individual bridge topics.

* The ast_bridge_cache() function now returns an ao2_container of
  ast_bridge_snapshots rather than a container of stasis_messages
  therefore you can't (and don't need to) call stasis_cache
  functions on it.

* The ast_bridge_topic_all() function now returns a normal topic
  not a cached one so you can't use stasis cache functions on it
  either.

* The ast_bridge_snapshot_type() stasis message now has the
  ast_bridge_snapshot_update structure as it's data.  It contains
  the last snapshot and the new one.

* ast_bridge_snapshot_get_latest() still returns the latest
  snapshot.

* cdr, cel, manager and ari have been updated to use the new
  arrangement.

Change-Id: I7049b80efa88676ce5c4666f818fa18ad1985369
---
M CHANGES
M UPGRADE.txt
M apps/confbridge/confbridge_manager.c
M include/asterisk/bridge.h
M include/asterisk/stasis_bridges.h
M main/Makefile
M main/bridge.c
M main/cdr.c
M main/cel.c
M main/manager_bridges.c
M main/stasis_bridges.c
M res/ari/resource_bridges.c
M res/stasis/app.c
13 files changed, 299 insertions(+), 212 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/27/10227/5
-- 
To view, visit https://gerrit.asterisk.org/10227
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7049b80efa88676ce5c4666f818fa18ad1985369
Gerrit-Change-Number: 10227
Gerrit-PatchSet: 5
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181001/096ef5a9/attachment.html>


More information about the asterisk-code-review mailing list