[Asterisk-code-review] bridges: Remove reliance on stasis caching (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10227 )

Change subject: bridges:  Remove reliance on stasis caching
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10227/4/main/cdr.c
File main/cdr.c:

https://gerrit.asterisk.org/#/c/10227/4/main/cdr.c@4309
PS4, Line 4309: 	bridge_subscription = stasis_forward_all(ast_bridge_topic_all(), cdr_topic);
Does this still work? The code which handles the cache update was not changed/altered.


https://gerrit.asterisk.org/#/c/10227/4/main/cel.c
File main/cel.c:

https://gerrit.asterisk.org/#/c/10227/4/main/cel.c@1463
PS4, Line 1463: 		ast_bridge_topic_all(),
Does this still work? The code which handles the cache update was not changed/altered.


https://gerrit.asterisk.org/#/c/10227/4/main/stasis_bridges.c
File main/stasis_bridges.c:

https://gerrit.asterisk.org/#/c/10227/4/main/stasis_bridges.c@330
PS4, Line 330: 	if (!old_snapshot) {
Can you clarify the scenario under which this happens with a comment?



-- 
To view, visit https://gerrit.asterisk.org/10227
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7049b80efa88676ce5c4666f818fa18ad1985369
Gerrit-Change-Number: 10227
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 01 Oct 2018 13:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181001/162531b6/attachment-0001.html>