[Asterisk-code-review] Revert "app voicemail: Remove need to subscribe to stasis" (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/10718 )

Change subject: Revert "app_voicemail: Remove need to subscribe to stasis"
......................................................................


Patch Set 1:

I just read a comment of origin patch which removed subscription to stasis...
"Since polling is only required when changes are being made to
mailboxes outside of app_voicemail and since the number of mailboxes
that don't have any subscribers is likely to be very low, all
mailboxes are now polled instead of just the ones with subscribers."

Where did the assumption come from that "the number of mailboxes that don't have any subscribers is likely to be very low"?
Imagine there are two asterisk servers running at the same time as master/backup or
as load balancing for thousands of SIP endpoints.
The IMAP storage is used for voicemail.
If master/backup the all endpoints have MWI subscription only on master server.
So only master server should poll IMAP mailboxes.
If load balancing the half of the endpoints have MWI subscription on the first server the others on the second server.

Without subscription to stasis both servers will poll all IMAP mailboxes.

I think the best way is to be able to switch on/off of the subscription to stasis using global option of voicemail.conf.
And this option should be ON (old behavior) for asterisk version 13 or it breaks compatibility. And it should be documented in CHANGES.


-- 
To view, visit https://gerrit.asterisk.org/10718
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I57b7b85e75d7dd97c742b5c69d718a0f61260c15
Gerrit-Change-Number: 10718
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 21:34:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181129/a2502e9d/attachment.html>