[Asterisk-code-review] pjproject bundled: check whether UPDATE is supported on outg... (asterisk[13])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/10717 )

Change subject: pjproject_bundled: check whether UPDATE is supported on outgoing calls
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

This can be cherry picked to 16 and master as well.

https://gerrit.asterisk.org/#/c/10717/1/third-party/pjproject/patches/0010-outgoing_connected_line_method_update.patch
File third-party/pjproject/patches/0010-outgoing_connected_line_method_update.patch:

https://gerrit.asterisk.org/#/c/10717/1/third-party/pjproject/patches/0010-outgoing_connected_line_method_update.patch@12
PS1, Line 12: +		    
Red space here.


https://gerrit.asterisk.org/#/c/10717/1/third-party/pjproject/patches/0010-outgoing_connected_line_method_update.patch@25
PS1, Line 25: +			if (i != allow->count) {
            : +			    /* UPDATE is present in Allow */
            : +			    inv->options |= PJSIP_INV_SUPPORT_UPDATE;
            : +			}
This could all be added to the above for loop by taking

inv->options |= PJSIP_INV_SUPPORT_UPDATE;

and adding it to the if statement before the break.



-- 
To view, visit https://gerrit.asterisk.org/10717
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I76cc06da4ca76ddd6dce814a8b97cc66b98aaf29
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 1
Gerrit-Owner: Pirmin Walthert <infos at nappsoft.ch>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Wed, 28 Nov 2018 19:47:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181128/f469ea95/attachment.html>