[Asterisk-code-review] res/res pjsip sip message: added sip message event notifier (asterisk[master])

Michael L. Young asteriskteam at digium.com
Wed Nov 28 09:12:13 CST 2018


Michael L. Young has posted comments on this change. ( https://gerrit.asterisk.org/10715 )

Change subject: res/res_pjsip_sip_message: added sip message event notifier
......................................................................


Patch Set 3:

In my view, ARI shouldn't be used for this intended purpose.

Debugging SIP messages falls on the Admin, not the App Developer.  This doesn't feel like the right interface to send these messages to.  I wouldn't want this level of detail going out over ARI.

As Josh mentioned, the tools are already there for proper debugging.


-- 
To view, visit https://gerrit.asterisk.org/10715
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dedcc678265ebb74d35e7a2f58bc4b5084bcfe1
Gerrit-Change-Number: 10715
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 15:12:13 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181128/6fd0dbe8/attachment-0001.html>


More information about the asterisk-code-review mailing list