[Asterisk-code-review] Fix deadlock handling subscribe req during res parking reload (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10701 )

Change subject: Fix deadlock handling subscribe req during res_parking reload
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10701/2/main/pbx.c
File main/pbx.c:

https://gerrit.asterisk.org/#/c/10701/2/main/pbx.c@3316
PS2, Line 3316: 		/* The extension has already been destroyed,
              : 		 * notify extension deactivation
              : 		 */
Is it now possible at all for this to be invoked multiple times?


https://gerrit.asterisk.org/#/c/10701/2/main/pbx.c@3835
PS2, Line 3835: 	if (hint->callbacks) {
              : 		ao2_callback(hint->callbacks, OBJ_NODATA | OBJ_MULTIPLE | OBJ_UNLINK, NULL, NULL);
              : 		ao2_ref(hint->callbacks, -1);
              : 	}
This could all just be replaced with ao2_cleanup(hint->callbacks);

This automatically unlinks everything.


https://gerrit.asterisk.org/#/c/10701/2/main/pbx.c@3989
PS2, Line 3989: 	if (!(message = stasis_message_create(hint_change_message_type(), hint))) {
Why the removal of the second reference and comment? Was there a leak previously?



-- 
To view, visit https://gerrit.asterisk.org/10701
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b03c3455b3b12b6f83cea4cc34f4b4b20444f7e
Gerrit-Change-Number: 10701
Gerrit-PatchSet: 2
Gerrit-Owner: Giuseppe Sucameli <sucameli at netresults.it>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 27 Nov 2018 12:22:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181127/f4adf267/attachment-0001.html>